Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to system contracts #17

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Add logging to system contracts #17

merged 4 commits into from
Aug 20, 2024

Conversation

lightclient
Copy link
Owner

In ACD 191 we discussed the idea of adding logging to the system contracts. There wasn't much push back so I've gone ahead and implemented it.

Waiting on a resolution for foundry-rs/foundry#8416 before merging to ensure tests pass correctly.

Copy link
Contributor

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lightclient lightclient marked this pull request as ready for review August 20, 2024 14:35
parithosh pushed a commit to ethpandaops/ethereum-genesis-generator that referenced this pull request Sep 25, 2024
update pectra contracts
([EIP-7002](https://eips.ethereum.org/EIPS/eip-7002) &
[EIP-7251](https://eips.ethereum.org/EIPS/eip-7251)) to the latest
compiled bytecode from lightclient/sys-asm#17

TODO:
* [x] update contract bytecode
* [x] verify contract bytecode matches with upcoming EIP change
* [x] update predeploy addresses according to upcoming EIP change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants